refactor: move disk I/O outside queue.sync in notifySuccess and skip redundant write on 304#376
Closed
Copilot wants to merge 2 commits intolanguages-apifrom
Closed
refactor: move disk I/O outside queue.sync in notifySuccess and skip redundant write on 304#376Copilot wants to merge 2 commits intolanguages-apifrom
Copilot wants to merge 2 commits intolanguages-apifrom
Conversation
Merged
…redundant write on 304 Co-authored-by: serhii-londar <15808174+serhii-londar@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update CocoaPods project references and UI adjustments
refactor: move disk I/O outside queue.sync in notifySuccess and skip redundant write on 304
Feb 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
notifySuccess, the 304 Not Modified path read from disk insidequeue.sync, blocking the serial queue with file I/O — contradicting the existing comment on the save path. Additionally, the data read from disk was immediately written back to the same file unnecessarily.Changes
loadLanguagesFromDisk(): disk read now happens outsidequeue.sync, consistent with how writes are handledsaveSupportedLanguagesis only called when fresh data arrived from the network (languages != nil); data already on disk doesn't need to be re-written💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.